Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cell organelle segmentation of Nile Red fluorescent images #537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bioimageiobot
Copy link
Collaborator

@bioimageiobot bioimageiobot commented Feb 18, 2023

This is an automatic PR created by the @bioimageiobot regarding changes to the resource item 10.5281/zenodo.7653695.
The following version(s) will be added:

Please review the changes and make sure the new item or version(s) pass the following check list:

  • Passed the BioImage.IO CI tests: static (and dynamic) validations
  • The meta information for the RDF item is complete
    • The tags are complete and describe the model
    • Naming is intuitive and descriptive, example: Multi-Organ Nucleus Segmentation (StarDist 2D)
    • Authors are provided
    • Documentation is complete
      • For models, include an overview, describe how the model is trained, what is the training data, how to use the model, how to validate the results and list the references. TODO: Model documentation template.
  • Approved by at least one of the BioImage.IO admin team member.

Maintainers: @[email protected]

Note: If you updated or re-uploaded another version for the current item on Zenodo, this PR won't be changed automatically. To proceed, you can do the following:

  1. Block this version, but keep looking for future versions: Edit the current resource.yaml and keep the top-level status field as accepted, but change the status under the current version to blocked.
  2. Accept this version and keep looking for future versions: Merge this PR for now.
  3. Keep proposed version(s) (and this resource in general if it is new) as pending: Close this PR without merging.

Then wait for the CI on the main branch to complete. It should detect the new version(s) and create another PR for the new version(s).

Previous PRs of this resource: none

@bioimageiobot
Copy link
Collaborator Author

@FynnBe
Copy link
Member

FynnBe commented Feb 20, 2023

Yay! CI passes!! 🥇

Couple small things:

Delete the test_input.npy and test_output.npy when used with illastic, because illastic only supports model files <100Mb.
--doc.md

  • ilastik (not illastic, btw) has no 100Mb model limit. If you experience an issue with the model size, plase open an ilastik bug report here. Please update doc.md and remove this last sentence.

  • I suggest to add 'Ilastik_Test.tif' as sample_inputs: [Ilastik_Test.tif]. Otherwise they will not be be included in the packaged model.

  • In your Ilastik_instruction.png (currently also not included in the package) under 1. you mark the remote NN workflow, but in the other screenshots it shows that you run the local NN workflow. If you like you can instead link the ilastik NN docs: https://www.ilastik.org/documentation/nn/nn . They are maintained and will stay up-to-date.

  • under maintainers[]:github_user you put your email, not your actual github user name. If you want to add your email, you can do so under maintainers[]:email. Please update your github_user in the rdf.yaml.

@FynnBe
Copy link
Member

FynnBe commented Feb 27, 2023

@KarlZhanghao , pinging you here as the maintainer

@esgomezm
Copy link
Contributor

esgomezm commented Oct 4, 2023

@FynnBe could we merge this one :) ?

@FynnBe
Copy link
Member

FynnBe commented Oct 4, 2023

@FynnBe could we merge this one :) ?

I'd say no. The above todo's should be adressed first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants