bugfix/missing-comma-was-creating-a-new-file-format #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evamaxfield
requested review from
toloudis,
hughes036,
SeanLeRoy,
yrkim98,
tyler-foster and
BrianWhitneyAI
|
I am also mirroring the change made here: AllenCellModeling/aicsimageio#543 In which imageio was bumped to a higher version to handle various ffmpeg differences |
|
I wonder if we can get the tests back to green |
Was trying to before I got blocked on time :/ will return to this in ~2 weeks. |
SeanLeRoy
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Found while working on napari stuff which tests for
pngsupport. If you try to read a PNG directly with this package'sReader, it works! If you try to read a PNG withBioImage, it fails because it doesn't have a plugin listing for"png"but does have one for"pngppm"because if there isn't a comma, Python will combine strings together 🙃🙃🙃.