-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support public s3 files automatically #67
Changes from all commits
8e2917a
a5ea2b7
e0b5e6f
f2fc602
3f0e57d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,10 +36,12 @@ | |
|
||
|
||
@pytest.fixture | ||
def sample_text_file(tmp_path: pathlib.Path) -> pathlib.Path: | ||
def sample_text_file( | ||
tmp_path: pathlib.Path, | ||
) -> typing.Generator[pathlib.Path, None, None]: | ||
example_file = tmp_path / "temp-example.txt" | ||
example_file.write_text("just some example text here") | ||
return example_file | ||
yield example_file | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated to main changeset, this is just to make the tests faster by only creating the file once since they seemed slow |
||
|
||
|
||
def np_random_from_shape( | ||
|
@@ -90,3 +92,9 @@ def __exit__( | |
subprocess.check_call( | ||
[sys.executable, "-m", "pip", "uninstall", "-y", self.package_name] | ||
) | ||
|
||
|
||
@pytest.fixture | ||
def dummy_plugin() -> typing.Generator[str, None, None]: | ||
with InstallPackage(package_path=DUMMY_PLUGIN_PATH, package_name=DUMMY_PLUGIN_NAME): | ||
yield DUMMY_PLUGIN_NAME | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated to main changeset, this is just to make the tests faster by only installing the plugin once and re-using this fixture since they seemed slow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the implication here, then, is that if you passed fs_kwargs={anon:True} in the initial bioImage constructor then s3 reads do work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah 👍 (and I believe were we to always pass
True
in the initial constructor then users that need to auth like for private buckets would fail, haven't tested that explicitly yet)