-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version number in header files #459
Conversation
Thanks, this is appreciated! The PR looks good, but there is one extra thing, though: add corresponding entries for the new files in the tbump file. |
Interesting tool, will look into this. |
Done |
Thanks! I've added some tests; let's wait for the pipelines to turn green. |
CI is a carnage, not sure why in most cases. Found this for find_package()
Is there a place to update for new headers to install ? May need this:
|
Indeed, that's missing. Btw, the sea of red is unrelated; it's happening because GitHub updated nodejs in the workflow actions and the ubuntu18 runner is therefore no longer supported. Let's ignore this problem. Let's focus on the workflows related to install. |
dffa074
to
022d2a2
Compare
@marcalff warning: I've rebased your branch into the current master. |
Well, by coincidence, not by necessity. I've looked through the pipelines, and the relevant ones are all green (the install/release pipelines succeed, and the sample pipelines succeed for the relevant tests, failing later only because of an unrelated problem which happens with PRs of non-owners). So I'm merging now. Thanks for your PR, and for sticking through this. |
Fixes #458
Changes