Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

chore: include lint script in Travis CI #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: include lint script in Travis CI #102

wants to merge 1 commit into from

Conversation

rkpattnaik780
Copy link
Contributor

Added a script to check linting.

fixes #101

@rkpattnaik780
Copy link
Contributor Author

@sarthak-sehgal is the lint script placed at current place or should we have another stage for it?

@sarthak-sehgal
Copy link
Contributor

Can we instead have npm run lint as a part of npm run test and include only the latter in Travis config?
I'm not sure whether this is the best practice - maybe @yochannah @DennisSchwartz would be able to tell that

@yochannah
Copy link

I think that sounds reasonable, @sarthak-sehgal!

@rkpattnaik780
Copy link
Contributor Author

@sarthak-sehgal I have made the change. Do have a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run Lint Script on Travis CI
3 participants
@rkpattnaik780 @sarthak-sehgal @yochannah