Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] PCA: Fix the variance spin. #1396

Merged
merged 1 commit into from
Jul 8, 2016
Merged

[FIX] PCA: Fix the variance spin. #1396

merged 1 commit into from
Jul 8, 2016

Conversation

thocevar
Copy link
Contributor

@thocevar thocevar commented Jul 1, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 1, 2016

Current coverage is 87.77%

Merging #1396 into master will not change coverage

@@             master      #1396   diff @@
==========================================
  Files            75         75          
  Lines          7434       7434          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           6525       6525          
  Misses          909        909          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 9d08c66...f621a90


def _on_cut_changed(self, line):
# cut changed by means of a cut line over the scree plot.
value = int(round(line.value()))
value = int(line.value())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this change: the value should be rounded, not rounded down.

@janezd
Copy link
Contributor

janezd commented Jul 1, 2016

I understand why three decimals -- to explain the difference due to rounding.

I don't understand what was wrong with the line. Can you tell me how to reproduce the problem that this PR fixes?

@thocevar
Copy link
Contributor Author

thocevar commented Jul 4, 2016

The displayed number of components does not match with the cut line (it's sometimes off by one) when changing the variance spin.

@janezd janezd merged commit a10ce24 into biolab:master Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants