[FIX] Lin and Log Regression: Prevent double commit #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.92%@@ master #1401 diff @@
==========================================
Files 77 77
Lines 7582 7584 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6668 6668
- Misses 914 916 +2
Partials 0 0
|
| to evaluation methods, i.e. {}(..., n_jobs=1). Setting n_jobs to 1. | ||
| '''.format(self.__class__.__name__), OrangeWarning) | ||
| mp_queue = mp.Queue() | ||
| n_jobs = 1 |
There was a problem hiding this comment.
These two lines are probably under-indented. They should be under except. Perhaps move them directly under except above and before warning.
BlazZupan
force-pushed
the
prevent-double-commit
branch
from
3727dcf to
d47bba7
Compare
BlazZupan
force-pushed
the
prevent-double-commit
branch
from
d47bba7 to
0f30c0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both linear and logistic regression committed the learner twice upon initialization. The first time when setting (changing) the attributes for initial setup, and the second time once the initialization was over and when the auto commit was set to True. If the widgets were connected to Test & Score, this resulted in running the testing (e.g. cross validation) twice.
Debugging of these widget lead to discovery a bug of crashing the parallel execution of cross-validation, but only when in debug mode and running through PyCharm on OS X. The fix is to change to sequential execution (
n_jobs = 1) but issuing a warning instead of raising an error.