Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] ImageViewer: Add a 'Preview' like window #1402

Merged
merged 2 commits into from
Jul 28, 2016

Conversation

ales-erjavec
Copy link
Contributor

Introduce a 'OSX Preview' like window to step through the images.

@codecov-io
Copy link

codecov-io commented Jul 1, 2016

Current coverage is 88.19% (diff: 100%)

Merging #1402 into master will not change coverage

@@             master      #1402   diff @@
==========================================
  Files            77         77          
  Lines          7613       7613          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           6714       6714          
  Misses          899        899          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 5fcb75c...90bb98f

@ales-erjavec ales-erjavec force-pushed the image-viewer-larger-preview branch from 275b4c6 to 0a07da0 Compare July 4, 2016 12:38
@ales-erjavec ales-erjavec changed the title [WIP][ENH]] owimageviewer: Add a 'Preview' like window [ENH] owimageviewer: Add a 'Preview' like window Jul 4, 2016
@BlazZupan
Copy link
Contributor

This is a great addition to Image Viewer. Has problems though if the images are very big (say 3000 x 3000). Then the preview window would cover the entire area of the screen. I can make preview window smaller, but as soon as I click on the main Image Viewer (or change the image by using arrow keys) the preview comes into focus in a full size, obscuring everything else.

This could be fixed with:

  • preview window having the same size (does not scale automatically to the size of the image)
  • preview can be made bigger or smaller, by the user, but stays the same with all the images
  • preview window remembers its position and size

When preview opens, it shows at front (correct), but then I am not able to click on other windows, say on Image Viewer. It would be better if Preview is treated just as a regular window that can also fall back when other windows are brought into focus.

Check also changing the images. If i do (1) bring the preview window, (2) click on the Image View window, the selected image changes with arrow keys, but the preview image stays the same.

@astaric
Copy link
Member

astaric commented Jul 13, 2016

I kind of like it how it work on osx.

Preview opens large automatically adapts it size to the image it displays until I resize it manually. Once manually resized, it will keep the size (and position) until closed.

@BlazZupan BlazZupan added this to the 3.3.7 milestone Jul 18, 2016
@ales-erjavec ales-erjavec force-pushed the image-viewer-larger-preview branch from 0a07da0 to 90bb98f Compare July 22, 2016 11:30
@ales-erjavec
Copy link
Contributor Author

The image window now remembers it it was resized by the user and keeps that size when switching between images. Hiding/showing the window will reset this state, reverting back to automatic resize.

@astaric astaric changed the title [ENH] owimageviewer: Add a 'Preview' like window [ENH] ImageViewer: Add a 'Preview' like window Jul 28, 2016
@astaric astaric merged commit 0d17649 into biolab:master Jul 28, 2016
@ales-erjavec ales-erjavec deleted the image-viewer-larger-preview branch September 28, 2016 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants