Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Select Rows: skip undefined TimeVariable filters #1429

Merged
merged 2 commits into from
Jul 8, 2016

Conversation

lanzagar
Copy link
Contributor

@lanzagar lanzagar commented Jul 8, 2016

... as they are skipped for ordinary ContinuousVariables.
Previous implementation parsed empty strings first into nan objects which were not skipped over later.

@codecov-io
Copy link

codecov-io commented Jul 8, 2016

Current coverage is 87.98%

Merging #1429 into master will not change coverage

@@             master      #1429   diff @@
==========================================
  Files            77         77          
  Lines          7582       7582          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           6671       6671          
  Misses          911        911          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by b77c021...64a9eab

@astaric astaric merged commit 7f464a6 into biolab:master Jul 8, 2016
@lanzagar lanzagar deleted the selectrowtime branch March 14, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants