Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix AdaBoost widgets and add some tests #1474

Merged
merged 7 commits into from
Jul 28, 2016

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Jul 20, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 20, 2016

Current coverage is 88.19% (diff: 100%)

Merging #1474 into master will not change coverage

@@             master      #1474   diff @@
==========================================
  Files            77         77          
  Lines          7613       7613          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           6714       6714          
  Misses          899        899          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 5fcb75c...a9b395a

@@ -26,39 +26,44 @@ class OWAdaBoostClassification(OWBaseLearner):
learning_rate = Setting(1.)
algorithm = Setting(0)

DEFAULT_BASE_ESTIMATOR = TreeLearner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this default base learner is always the same, might as well create a single class instance right here?

@kernc kernc mentioned this pull request Jul 20, 2016
@astaric astaric merged commit b7df0f7 into biolab:master Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants