Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Confusion matrix: fix selected_learner setting #1523

Merged
merged 2 commits into from
Sep 9, 2016

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Aug 26, 2016

Fixes #1505.

The actual fix is in gui.py, in the constructor for ControlledList. The remainder of the PR deals with another related error: the widget wanted to store the selected_learner as an int, but since it represents the selection in gui.listBox, it kept changing to list at various places. It's simpler/safer to have a single-element list.

@janezd janezd force-pushed the fix-conf-matrix-learner branch from 99e3dfd to e0c7031 Compare August 26, 2016 09:55
@codecov-io
Copy link

codecov-io commented Aug 26, 2016

Current coverage is 88.26% (diff: 100%)

Merging #1523 into master will not change coverage

@@             master      #1523   diff @@
==========================================
  Files            77         77          
  Lines          7624       7624          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           6729       6729          
  Misses          895        895          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 2b02285...87056b5

@janezd janezd force-pushed the fix-conf-matrix-learner branch 3 times, most recently from 3aea927 to 8ce394f Compare August 26, 2016 12:02
@janezd janezd force-pushed the fix-conf-matrix-learner branch from 8ce394f to 87056b5 Compare August 26, 2016 12:10
@PrimozGodec PrimozGodec self-assigned this Sep 9, 2016
@PrimozGodec PrimozGodec merged commit d1e3532 into biolab:master Sep 9, 2016
@janezd janezd deleted the fix-conf-matrix-learner branch April 5, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with Confusion matrix
3 participants