[FIX] Fixed svg function to return svg chart together with container div for highcharts #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore last > was missing.
Current coverage is 88.69% (diff: 100%)@@ master #1541 diff @@
==========================================
Files 77 78 +1
Lines 7624 8108 +484
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6730 7191 +461
- Misses 894 917 +23
Partials 0 0
|
PrimozGodec
changed the title
…iew and returns whole div instead only svg part. It is required in report that also axis labels are shown.
PrimozGodec
force-pushed
the
svg-export-fix
branch
from
62db648
to
61e0a1d
Compare
PrimozGodec
changed the title
|
@kernc It is corrected now. |
kernc
suggested changes
Sep 16, 2016
| @@ -325,6 +325,12 @@ def _on_selected_points(self, points): | |||
| self._selection_callback([np.sort(selected).astype(int) | |||
| for selected in points]) | |||
|
|
|||
| def svg(self): | |||
| """ Return SVG string of the first SVG element on the page, or | |||
| raise ValueError if not any. """ | |||
There was a problem hiding this comment.
Please add a comment why this is overridden and why a non-SVG is returned.
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is required that also axis labels are provided in a report.
Also fixed svg function in webview to take return whole svg. Before svg was returned without last
>