Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owimageviewer: Open local images directly #1550

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

ales-erjavec
Copy link
Contributor

Using QNetworkAccessManager to 'retrieve' many local files can lead
to temporarily running out of available file descriptors.

Presumably this is because the associated open fd is not closed
until the QNetworkReply is actually deleted (and not just closed).

@codecov-io
Copy link

codecov-io commented Sep 9, 2016

Current coverage is 88.28% (diff: 100%)

Merging #1550 into master will not change coverage

@@             master      #1550   diff @@
==========================================
  Files            77         77          
  Lines          7629       7629          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           6735       6735          
  Misses          894        894          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update d793eaf...1dd7873

Using QNetworkAccessManager to 'retrieve' many local files can lead
to temporarily running out of available file descriptors.

Presumably this is because the associated open fd is not closed
until the QNetworkReply is actually deleted (and not just closed).
@ales-erjavec ales-erjavec force-pushed the image-viewer-local-files branch from 764d10a to 1dd7873 Compare September 9, 2016 08:26
@astaric
Copy link
Member

astaric commented Sep 9, 2016

I cannot reproduce the original problem on my machine. @BlazZupan, can you check if this solves the issue for you?

@ales-erjavec
Copy link
Contributor Author

I cannot reproduce the original problem on my machine. @BlazZupan, can you check if this solves the issue for you?

Try running orange-canvas like so:

(ulimit -n 150; orange-canvas;)

(adjusting the limit appropriately to trigger the error)

@janezd
Copy link
Contributor

janezd commented Sep 9, 2016

Perhaps related: trying to view the images from https://www5.cs.fau.de/fileadmin/research/datasets/fundus-images/all.zip in the Image Viewer on Windows shows the first 20 or so out of 45 images and then complains that it cannot open the file.

I've seen this on somebody's computer, but cannot replicate it neither on Mac nor on Windows.

@BlazZupan
Copy link
Contributor

Works fine on Mac. Should be checked on Win.

@astaric
Copy link
Member

astaric commented Sep 12, 2016

I am merging this. Testing on windows can be done with daily builds, when they become available.

@astaric astaric merged commit 8ae84ef into biolab:master Sep 12, 2016
@ales-erjavec ales-erjavec deleted the image-viewer-local-files branch September 28, 2016 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants