[ENH] canvas: Indicate runtime state on links #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.69% (diff: 100%)@@ master #1554 diff @@
==========================================
Files 78 78
Lines 8108 8108
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7191 7191
Misses 917 917
Partials 0 0
|
|
Have you considered switching the state that is shown on widgets? (Like highlighting the channels that do not pass any data)? |
BlazZupan
reviewed
Sep 15, 2016
There was a problem hiding this comment.
Very nice idea! I propose to mark the connections with no tokens (None) and leave all connections with tokens as they are (grey). Connection with no tokens can be shown as broken, the way we show now the connections that are disabled. For disabled connections use "a cut line" symbol: break connection in the middle and display the cut with two lines, something like ---//--- (except that the line is full and the only break really is between //)
* Disabled links are now displayed with a single disconnected symbol in the middle. * The dash line style is re-used for links with no data on them.
ales-erjavec
force-pushed
the
canvas/display-state
branch
from
0f2e705 to
996a236
Compare
astaric
approved these changes
Sep 21, 2016
ajdapretnar
approved these changes
Sep 21, 2016
|
It looks great. |
janezd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track and display the state of signal propagation on links in the canvas.