[ENH] Remote reporting of unexpected errors #1558

kernc · 2016-09-15T00:49:10Z

No description provided.

codecov-io · 2016-09-15T00:58:04Z

Current coverage is 88.65% (diff: 100%)

Merging #1558 into master will not change coverage

@@             master      #1558   diff @@
==========================================
  Files            78         78          
  Lines          8121       8121          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7200       7200          
  Misses          921        921          
  Partials          0          0

Powered by Codecov. Last update 5b5e451...0fca652

astaric · 2016-09-15T12:50:52Z

Orange/canvas/__main__.py

-
-    # cmd line option overrides settings / no redirect is possible
-    # under ipython
-    if options.no_redirect or running_in_ipython():


Does running Orange from ipython shell now work without the need to disable redirects?

For me and @lanzagar works just as well as on master.

astaric · 2016-09-15T12:56:59Z

Orange/canvas/application/canvasmain.py


+class DockWidget(QDockWidget):


The old name signified that this is a windows that can be docked. The new one suggests that extending classes can only be used as dock components.

That's correct. Docks that can be docked or undocked but they aren't windows in themselves.

astaric · 2016-09-15T13:21:46Z

Orange/canvas/application/canvasmain.py

                    )

        self.show_report_action = \
-            QAction(self.tr("Show Report View"), self,
+            QAction(self.tr("Show Report Window"), self,


I would rename this option to Report. Show is redundant as this action is located in the View menu and can be considered as View > Report.

astaric · 2016-09-15T13:23:05Z

Orange/canvas/application/canvasmain.py

-            QAction(self.tr("Show Output View"), self,
-                    toolTip=self.tr("Show application output."),
-                    triggered=self.show_output_view,
+            QAction(self.tr("Show Output Dock"), self,


Could this be renamed to Log?

And should we redirect all logs that currently go to the console to this window (i.e. when run with -l 4 flag)?

astaric · 2016-09-15T13:28:00Z

Orange/canvas/application/errorreporting.py

+        cache_key = '{}:{}'.format(
+            frame.tb_frame.f_globals.get('__name__', frame.tb_frame.f_code.co_filename),
+            frame.tb_lineno)
+        if cache_key in cls._cache:


I see the point in not showing the send error report dialog if an error occurs multiple times, but some kind of message notifying the user that something went wrong (again) would be nice.

astaric · 2016-09-15T13:28:19Z

Orange/canvas/application/errorreporting.py

+
+        if canvas:
+            filename = mkstemp(prefix='ows-', suffix='.ows.xml')[1]
+            # Prevent excepthook prinitng the same exception when


astaric · 2016-09-15T13:29:02Z

Orange/canvas/application/outputview.py

-
-        font.setFamily("Monaco")
-        font.setPointSize(12)
+        font.setStyleHint(QFont.Monospace)


Was the error fixed in debian squeeze, or is to old to support even for debian standards?

Squeeze is no longer supported. Obviously Squeeze at that time had too old Qt that didn't yet contain QFont.Monospace.

astaric · 2016-09-15T13:29:26Z

Orange/canvas/application/outputview.py

@@ -201,119 +195,39 @@ def __exit__(self, *args):
        self.charformat = None


-class QueuedCallEvent(QEvent):


Why is this not needed anymore?

IIUC it never was needed. If the subscribers to TextStream.stream signal, the only user of this class, prefer queued connections, they can mark them such in their .connect() calls. Otherwise, Qt signal connections are direct if the emitter and handler are in the same thread, queued otherwise.

astaric · 2016-09-15T13:31:50Z

Orange/canvas/__main__.py

+
+    log.info("Entering main event loop.")
+    try:
+        with redirect_stderr(stderr), redirect_stdout(stdout):


The commit message says tee instead of redirecting, while the function called here still says redirect.

astaric · 2016-09-15T13:33:28Z

Orange/canvas/application/errorreporting.py

+REPORT_POST_URL = 'http://qa.orange.biolab.si/error-report/v1/'
+ISSUE_TRACKER_URL = 'https://github.com/biolab/orange3'
+
+THUMBSUP_IMAGE = os.path.join(os.path.dirname(__file__), 'thumbsup.png')


Could we use a picture of an Orange orange?

astaric · 2016-09-15T13:34:24Z

Orange/canvas/config.py

-
-     ("output/dockable", bool, True, "Allow output window to be docked"),
-
-     ("help/stay-on-top", bool, True, ""),


Why is the stay-on-top-functionality no longer needed?

Undocked docks stay on top.

astaric · 2016-09-15T13:36:38Z

Orange/canvas/application/errorreporting.py

+        STACK_TRACE = 'Stack Trace'
+
+    def __init__(self, data):
+        icon = QApplication.style().standardIcon(QStyle.SP_MessageBoxCritical)


OSX uses yellow icons for this type of windows:

https://support.apple.com/library/content/dam/edam/applecare/images/en_US/osx/report.png

The comments timeline doesn't show for it, but the icon has been changed into warning.

ajdapretnar · 2016-09-15T16:47:01Z

This PR. ❤️

ajdapretnar · 2016-09-21T09:24:10Z

So far so good on Windows, but is there already a website I could check to see whether my two errors came through?
p.s. The GUI is a bit meh, but this PR is so great I don't even care.

astaric · 2016-09-22T10:03:04Z

Orange/canvas/application/errorreporting.py

+                            timeout=10,
+                            data=urlencode(data).encode('utf8'))
+                except Exception as e:
+                    log.error('%s: %s', e.__class__.__name__, e.args[0])


What about
log.exception("Error reporting failed", exc_info=e)

lanzagar · 2016-09-23T09:41:58Z

Orange/canvas/application/errorreporting.py

+
+
+REPORT_POST_URL = 'http://qa.orange.biolab.si/error-report/v1/'
+ISSUE_TRACKER_URL = 'https://github.com/biolab/orange3'


Not used anymore?

lanzagar · 2016-09-23T13:39:16Z

Works and is a much needed feature, so I suggest merging and actively testing in development, before it gets into stable (hopefully soon).

kernc force-pushed the error-reporting branch from f3c1b4e to a4614a3 Compare September 15, 2016 00:59

astaric reviewed Sep 15, 2016

View reviewed changes

astaric requested changes Sep 15, 2016

View reviewed changes

kernc force-pushed the error-reporting branch 5 times, most recently from b07be9d to d996696 Compare September 15, 2016 16:39

kernc force-pushed the error-reporting branch from d996696 to 5df33a3 Compare September 15, 2016 17:47

astaric approved these changes Sep 16, 2016

View reviewed changes

kernc force-pushed the error-reporting branch from 5df33a3 to 7875b1e Compare September 16, 2016 09:12

kernc added 4 commits September 16, 2016 12:27

canvas/DockableWindow: remember floating/visible setting, rationalize

5111822

canvas/menu: move Show Output and Show Report into View menu + rename

3d56958

[ref] canvas: rename output_dock -> log_dock

7b644e5

canvas: tee stdout/stderr into Output dock instead of redirecting

356d7f5

kernc force-pushed the error-reporting branch from 7875b1e to d733086 Compare September 16, 2016 10:27

astaric reviewed Sep 22, 2016

View reviewed changes

kernc force-pushed the error-reporting branch from d733086 to 7f4caee Compare September 22, 2016 14:10

lanzagar reviewed Sep 23, 2016

View reviewed changes

kernc force-pushed the error-reporting branch 2 times, most recently from 5eb51c6 to 10a7729 Compare September 23, 2016 12:34

canvas: add remote error reporting on unhandled exception

0fca652

kernc force-pushed the error-reporting branch from 10a7729 to 0fca652 Compare September 23, 2016 12:34

lanzagar merged commit 2bc7ec3 into biolab:master Sep 23, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENH] Remote reporting of unexpected errors #1558

[ENH] Remote reporting of unexpected errors #1558

kernc commented Sep 15, 2016

codecov-io commented Sep 15, 2016 •

edited

Loading

astaric Sep 15, 2016

kernc Sep 15, 2016

astaric Sep 15, 2016

kernc Sep 15, 2016

astaric Sep 15, 2016

astaric Sep 15, 2016

astaric Sep 15, 2016

kernc Sep 15, 2016

astaric Sep 15, 2016

astaric Sep 15, 2016

kernc Sep 15, 2016

astaric Sep 15, 2016

kernc Sep 15, 2016 •

edited

Loading

astaric Sep 15, 2016

astaric Sep 15, 2016

kernc Sep 15, 2016

astaric Sep 15, 2016

kernc Sep 15, 2016

astaric Sep 15, 2016

kernc Sep 15, 2016

ajdapretnar commented Sep 15, 2016

ajdapretnar commented Sep 21, 2016

astaric Sep 22, 2016

lanzagar Sep 23, 2016

lanzagar commented Sep 23, 2016

		@@ -201,119 +195,39 @@ def __exit__(self, *args):
		self.charformat = None


		class QueuedCallEvent(QEvent):


		("output/dockable", bool, True, "Allow output window to be docked"),

		("help/stay-on-top", bool, True, ""),



		REPORT_POST_URL = 'http://qa.orange.biolab.si/error-report/v1/'
		ISSUE_TRACKER_URL = 'https://github.com/biolab/orange3'

[ENH] Remote reporting of unexpected errors #1558

[ENH] Remote reporting of unexpected errors #1558

Conversation

kernc commented Sep 15, 2016

codecov-io commented Sep 15, 2016 • edited Loading

Current coverage is 88.65% (diff: 100%)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kernc Sep 15, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajdapretnar commented Sep 15, 2016

ajdapretnar commented Sep 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lanzagar commented Sep 23, 2016

codecov-io commented Sep 15, 2016 •

edited

Loading

kernc Sep 15, 2016 •

edited

Loading