Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] OWRank: Widget improvements #1560

Merged
merged 1 commit into from
Sep 23, 2016
Merged

[ENH] OWRank: Widget improvements #1560

merged 1 commit into from
Sep 23, 2016

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Sep 15, 2016

Enable selection of scoring method. Scores are computed only when checked and when deselected stored in cache for later use.
Attribute selection is context dependent and progress bar is added to the widget to show percentage of computed scores.

Fixes #1547 and #1556

@codecov-io
Copy link

codecov-io commented Sep 15, 2016

Current coverage is 88.66% (diff: 100%)

Merging #1560 into master will not change coverage

@@             master      #1560   diff @@
==========================================
  Files            78         78          
  Lines          8111       8111          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7192       7192          
  Misses          919        919          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 69fc2e1...fc5caa1

@VesnaT VesnaT force-pushed the rank branch 2 times, most recently from ff1a294 to 5f76e67 Compare September 15, 2016 13:12
@janezd janezd self-assigned this Sep 16, 2016
@ajdapretnar
Copy link
Contributor

I like this very much. Not sure if this is a part of this PR or not, but there's an issue with Report. When reporting on all possible scoring methods for discrete class, the last few columns fall out of view. When saving to .pdf, columns names are shifted. Could probably be fixed in another PR I reckon.

@ajdapretnar
Copy link
Contributor

Important note: load housing.tab and connect it to Rank. Then connect PCA to Rank and Logistic Regression (it is wrong, I know). The widget crashes. Before it it displayed only the error message. Please check.

@janezd
Copy link
Contributor

janezd commented Sep 17, 2016

Rebase, please.

While you're at it, can you also handle the case in which the data has no class, but it has an outside scorer (e.g. PCA). See issue #1556. As shown in PR #1566, it suffices to remove the error message and setting the data to None - except not in that you mustn't do it in set_learner.

@VesnaT VesnaT force-pushed the rank branch 2 times, most recently from afff0b4 to 950d87e Compare September 19, 2016 10:30
kernc added a commit to kernc/orange3 that referenced this pull request Sep 19, 2016
@kernc
Copy link
Contributor

kernc commented Sep 19, 2016

When saving to .pdf, columns names are shifted.

Will be fixed in 71b62c8

@ajdapretnar
Copy link
Contributor

ajdapretnar commented Sep 21, 2016

Rank is not working for me anymore. @VesnaT can you please check?

Sorry, all good.

Scores are computed only when checked and when deselected stored in cache for later use.
Attribute selection is context dependent and progress bar is added to the widget to show percentage of computed scores.
Copy link
Contributor

@ajdapretnar ajdapretnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me. Should I wait for the fix Janez is talking about (no class) and then merge?

@janezd
Copy link
Contributor

janezd commented Sep 23, 2016

You can wait but you don't have to. It can be fixed in another PR.

@janezd janezd merged commit 793fc51 into biolab:master Sep 23, 2016
kernc added a commit to kernc/orange3 that referenced this pull request Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rank Widget Improvements
5 participants