[FIX] gui: Add a push button class adapted for variable width text #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.66% (diff: 100%)@@ master #1614 diff @@
==========================================
Files 78 78
Lines 8124 8124
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7203 7203
Misses 921 921
Partials 0 0
|
lanzagar
reviewed
Sep 30, 2016
| QPushButton subclass with an sizeHint method to better support settable | ||
| variable width button text. | ||
|
|
||
| Use this of class instead of the QPushButton when the button will |
|
"fix auto_commit generated layout" - what is the best way to see the difference? / where were previous problems noticeable? |
ales-erjavec
force-pushed
the
variable-text-button
branch
from
d469792
to
10ec3bb
Compare
Use it to ensure `auto_commit` generated layout has stable geometry.
ales-erjavec
force-pushed
the
variable-text-button
branch
from
10ec3bb
to
06832aa
Compare
When the auto commit checkbox is toggled the layout would change. Most noticeable on widgets with fixed size constraint like most learners. |
|
OK, apparently that was an issue on OSX (looks annoying). |
lanzagar
approved these changes
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it to fix
auto_commitgenerated layout.