Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] errorreporting: Fix an KeyError for a missing 'Widget Module' entry #1625

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

ales-erjavec
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 3, 2016

Current coverage is 88.66% (diff: 100%)

Sunburst

No coverage report found for master at cc4d147.

Powered by Codecov. Last update cc4d147...34db15f

@janezd
Copy link
Contributor

janezd commented Oct 3, 2016

@ales-erjavec, is this the bug that triggered endless recursion? (@kernc)

@kernc kernc force-pushed the error-report-key-error branch from 18dc15b to 34db15f Compare October 5, 2016 16:53
@kernc
Copy link
Contributor

kernc commented Oct 5, 2016

Not entirely sure what triggers the recursion since the excepthook is patched to prevent reentry. But the code was bug and this fixes it. 😄

@kernc kernc merged commit 751f676 into biolab:master Oct 5, 2016
@ales-erjavec ales-erjavec deleted the error-report-key-error branch November 14, 2017 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants