Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owsql: Fix bug when using connection before established #1638

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

lanzagar
Copy link
Contributor

@lanzagar lanzagar commented Oct 7, 2016

Move the attempt to create missing extensions right after the connection to the database is established.
Before, this could be attempted even before the connection existed, which resulted in an error (reproduced by setting parameters and before refreshing tick a checkbox).

@codecov-io
Copy link

codecov-io commented Oct 7, 2016

Current coverage is 88.69% (diff: 100%)

Merging #1638 into master will not change coverage

@@             master      #1638   diff @@
==========================================
  Files            78         78          
  Lines          8148       8148          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7227       7227          
  Misses          921        921          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 97863cf...fe36975

@astaric astaric merged commit 349ce1b into biolab:master Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants