[FIX] Switch Sieve to DomainModel, which also fixes VizRank crash on meta attributes #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
fix-sieve-rank2
branch
from
68c34fe
to
7e454bd
Compare
Current coverage is 88.91% (diff: 100%)@@ master #1642 diff @@
==========================================
Files 82 82
Lines 8847 8847
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7866 7866
Misses 981 981
Partials 0 0
|
janezd
force-pushed
the
fix-sieve-rank2
branch
from
7e454bd
to
77ebfb7
Compare
janezd
changed the title
janezd
force-pushed
the
fix-sieve-rank2
branch
from
77ebfb7
to
a5e7dcc
Compare
3 tasks
janezd
force-pushed
the
fix-sieve-rank2
branch
2 times, most recently
from
c9bb195
to
e3c8558
Compare
janezd
changed the title
janezd
force-pushed
the
fix-sieve-rank2
branch
from
e3c8558
to
af55e9c
Compare
…e domain includes meta attributes
astaric
force-pushed
the
fix-sieve-rank2
branch
from
af55e9c
to
50cc5ec
Compare
|
I have rebased the commits onto the latest master as there were some conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1546.
Breaks compatibility with old settings. See #1672 for a similar problem with the scatter plot.Blocked by #1724 and #1727.