[FIX] Fix pythagoras tree tooltip for regression trees #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.73% (diff: 100%)@@ master #1660 diff @@
==========================================
Files 78 78
Lines 8150 8150
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7232 7232
Misses 918 918
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pythagoras tree widget tooltip for regression trees and improve the
mainfunction for easier debugging.The tooltip originally tried to emulate the classification one where the samples are written like this:
Obviously this can't be emulated in a regression problem, but I missed this problem. This fix changes the tooltip to simply shows the # of samples in the node, which makes more sense.