Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Canvas: Always show the link dialog if the user holds Shift #1673

Merged
merged 1 commit into from
Oct 21, 2016

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Oct 18, 2016

Numerous widgets now provide the signal with annotated data (#1655), which will be used quite often, but it is not the default output. Selected data should stay the default; even always showing the dialog would be annoying. The user thus has to connect the widgets, double click the link, and reroute. This annoyed me a lot.

I suggest that holding shift while connecting should trigger opening the link dialog. To not confuse the user, this should happen even when there's just a single signal on both sides.

I know this feature is a bit of easter egg, but a really useful one.

@ales-erjavec, the change is really simple. Have I overlooked anything?

@codecov-io
Copy link

codecov-io commented Oct 18, 2016

Current coverage is 89.38% (diff: 100%)

Merging #1673 into master will not change coverage

@@             master      #1673   diff @@
==========================================
  Files            79         79          
  Lines          8593       8593          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7681       7681          
  Misses          912        912          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update c1f3794...a6cb8f7

@ales-erjavec
Copy link
Contributor

Please initialize the flag in the class __init__ and clear it after the link is created.

You might also make it slightly less of an easter egg and mention this in the QuickHelpTipEvent that is posted in the mousePressEvent method

@janezd janezd force-pushed the force-show-link-dlg branch from 680614a to a6cb8f7 Compare October 20, 2016 20:31
@janezd
Copy link
Contributor Author

janezd commented Oct 20, 2016

Done, I guess. Thanks for the tip about the tip!

@kernc
Copy link
Contributor

kernc commented Oct 21, 2016

The feature stops being an easter egg if you document it also in the user docs.

@lanzagar lanzagar merged commit 7c9b1ad into biolab:master Oct 21, 2016
@astaric astaric modified the milestone: 3.3.9 Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants