[FIX] OWTable: Sort Continuous metas as floats; not strings #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.38% (diff: 100%)@@ master #1678 diff @@
==========================================
Files 79 79
Lines 8593 8593
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7681 7681
Misses 912 912
Partials 0 0
|
lanzagar
requested changes
Oct 21, 2016
| @@ -1015,6 +1015,8 @@ def columnSortKeyData(self, column, role): | |||
| and role == TableModel.ValueRole: | |||
| col_view, _ = self.source.get_column_view(coldesc.var) | |||
| col_data = numpy.asarray(col_view) | |||
| if coldesc.var.is_continuous: # continuous from metas have dtype object; cast it to float | |||
There was a problem hiding this comment.
Please avoid comments on the same line when that results in line length > 80.
Continuous variables inside meta attributes are currently sorted by their string represenation and not by float values. This happens since dtype for metas is object and we map all object to strings before sorting. This PR checks whether the sorting variable is ContinuousVariable and casts values to floats.
nikicc
force-pushed
the
continuous-metas-sorting
branch
from
4c3a657
to
4f9931e
Compare
|
@lanzagar I moved it inside the if. Is this better? |
|
It is. |
lanzagar
approved these changes
Oct 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuous variables inside meta attributes are currently sorted by their string represenation and not by float values. This happens since dtype for metas is object and we map all object to strings before sorting. This PR checks whether the sorting variable is ContinuousVariable and casts values to floats.