-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add appveyor configuration #1693
Conversation
The test unfortunately take a lot of time (at least in their current state) so I do not think running on every pull request is an option. |
Current coverage is 88.91% (diff: 100%)@@ master #1693 diff @@
==========================================
Files 82 82
Lines 8847 8847
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7866 7866
Misses 981 981
Partials 0 0
|
888b505
to
b02e1ed
Compare
|
dbc31c4
to
c72a910
Compare
@ales-erjavec If the slowness of the test is the only problem, we can enable the integration, but mark it as optional. This way, appveyor builds would run, but if they take too long, we can still merge. |
c72a910
to
977fd30
Compare
Sure, why not. |
The trusty build that caused the failing python3.4 tests on travis has beed disabled. Can you rebase onto the latest master so we can check if everything is in order now? |
7f3df44
to
5851858
Compare
Explicitly count the number of nodes with at least min_leaf instances.
Due to random instance selection in the relieff algorithm the 'relationship' variable is not always in the top 2 best scoring list.
Fix a `PermissionError: [WinError 32] The process cannot access the file because it is being used by another process` error due to a file descriptor leak
5851858
to
f14d388
Compare
Add appveyor CI service configuration for testing on Windows.
An example output can be viewed here.