Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add appveyor configuration #1693

Merged
merged 6 commits into from
Nov 18, 2016
Merged

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Oct 28, 2016

Add appveyor CI service configuration for testing on Windows.
An example output can be viewed here.

@ales-erjavec
Copy link
Contributor Author

The test unfortunately take a lot of time (at least in their current state) so I do not think running on every pull request is an option.

@codecov-io
Copy link

codecov-io commented Oct 28, 2016

Current coverage is 88.91% (diff: 100%)

Merging #1693 into master will not change coverage

@@             master      #1693   diff @@
==========================================
  Files            82         82          
  Lines          8847       8847          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7866       7866          
  Misses          981        981          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 92bba3f...f14d388

@ales-erjavec ales-erjavec mentioned this pull request Oct 28, 2016
@ales-erjavec ales-erjavec changed the title [WIP][ENH] Add appveyor configuration [ONHOLD] [ENH] Add appveyor configuration Oct 28, 2016
@ales-erjavec
Copy link
Contributor Author

ales-erjavec commented Oct 28, 2016

Blocked on #1698

@ales-erjavec ales-erjavec force-pushed the ci-appveyor branch 3 times, most recently from dbc31c4 to c72a910 Compare November 4, 2016 13:17
@astaric
Copy link
Member

astaric commented Nov 8, 2016

@ales-erjavec If the slowness of the test is the only problem, we can enable the integration, but mark it as optional. This way, appveyor builds would run, but if they take too long, we can still merge.

@ales-erjavec ales-erjavec changed the title [ONHOLD] [ENH] Add appveyor configuration [ENH] Add appveyor configuration Nov 9, 2016
@ales-erjavec
Copy link
Contributor Author

If the slowness of the test is the only problem, we can enable the integration, but mark it as optional. This way, appveyor builds would run, but if they take too long, we can still merge.

Sure, why not.

@astaric
Copy link
Member

astaric commented Nov 11, 2016

The trusty build that caused the failing python3.4 tests on travis has beed disabled. Can you rebase onto the latest master so we can check if everything is in order now?

@ales-erjavec ales-erjavec force-pushed the ci-appveyor branch 4 times, most recently from 7f3df44 to 5851858 Compare November 17, 2016 11:07
Explicitly count the number of nodes with at least min_leaf instances.
Due to random instance selection in the relieff algorithm the
'relationship' variable is not always in the top 2 best scoring list.
Fix a `PermissionError: [WinError 32] The process cannot access the file
because it is being used by another process` error due to a file
descriptor leak
@astaric astaric merged commit 7b5f2be into biolab:master Nov 18, 2016
@astaric astaric modified the milestone: 3.3.9 Nov 28, 2016
@ales-erjavec ales-erjavec deleted the ci-appveyor branch January 27, 2017 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants