Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWLoadClassifier: Show message on unpickling error #1752

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Nov 14, 2016

Issue

Load Classifier widget crashes instead of reporting an error when unpickling fails.

Description of changes

Show the message.

Includes
  • Code changes
  • Tests

@janezd janezd mentioned this pull request Nov 14, 2016
3 tasks
@codecov-io
Copy link

Current coverage is 88.90% (diff: 100%)

Merging #1752 into master will increase coverage by 0.03%

@@             master      #1752   diff @@
==========================================
  Files            82         82          
  Lines          8819       8845    +26   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           7838       7864    +26   
  Misses          981        981          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 909a119...e32c4ea

raise # TODO: error reporting
except os.error:
raise # TODO: error reporting
except (pickle.UnpicklingError, os.error, EOFError):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.errorOSError

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gladly. It was there before, so I kept it, but I didn't like it either. Fixed.

@janezd janezd force-pushed the loadclassifier-pickle-error branch from e32c4ea to bde7ec7 Compare November 16, 2016 18:01
@kernc kernc changed the title OWLoadClassifier: Show message about unpickling error [FIX] OWLoadClassifier: Show message on unpickling error Nov 16, 2016
@kernc kernc merged commit 5d08c54 into biolab:master Nov 16, 2016
@janezd janezd deleted the loadclassifier-pickle-error branch April 5, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants