[FIX] OWImageViewer: Fix Selection Indexing #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For data sets with missing images indexing was incorrect. Instead of using positions in the Data Table, positions from the ThumbnailView were used, resulting in mismatch betwen selected instances and instances on the output.
Current coverage is 89.24% (diff: 100%)@@ master #1861 diff @@
==========================================
Files 86 86
Lines 9100 9100
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8121 8121
Misses 979 979
Partials 0 0
|
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 6, 2017
[FIX] OWImageViewer: Fix selection with missing values (cherry picked from commit 04be225)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 10, 2017
[FIX] OWImageViewer: Fix selection with missing values (cherry picked from commit 04be225)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 11, 2017
[FIX] OWImageViewer: Fix selection with missing values (cherry picked from commit 04be225)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 13, 2017
[FIX] OWImageViewer: Fix selection with missing values (cherry picked from commit 04be225)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 18, 2017
[FIX] OWImageViewer: Fix selection with missing values (cherry picked from commit 04be225)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
For data sets with missing images indexing was incorrect. Instead of using positions in the Data Table, positions from the ThumbnailView were used, resulting in mismatch betwen selected instances and instances on the output.
Description of changes
Use correct indices for output mask.
Includes