[FIX] Treeviewer sklearn tree compatibility #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pavlin-policar
force-pushed
the
treeviewer-adapter
branch
from
93cb1e1
to
e769ff3
Compare
Current coverage is 89.26% (diff: 100%)@@ master #1870 diff @@
==========================================
Files 86 86
Lines 9103 9103
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8126 8126
Misses 977 977
Partials 0 0
|
pavlin-policar
force-pushed
the
treeviewer-adapter
branch
from
96a9f07
to
d403402
Compare
pavlin-policar
force-pushed
the
treeviewer-adapter
branch
from
d403402
to
19357a7
Compare
|
@kernc Could you please take a look at this as well. This builds upon the PR closed yesterday that fixed compatibility between the Pythagorean forest and Pythagorean trees. This one changes TreeViewer to accept the input of Pythagorean forests as well. This is kind of high priority and should be merged ASAP. |
astaric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Trees output from Pythagorean forest are not compatible with the TreeViewer widget.
Description of changes
Having established that #1850 would cause far too much confusion and make the overall tree model code completely non-understandable (Adapter for sklearn trees, but now also vice versa, tree model for sklearn trees?), I've taken another stab at it.
It seems that converting the TreeViewer widget to use the TreeAdapter actually doesn't require any major changes at all. So this is what I did in this PR, TreeViewer now uses the TreeAdapter, just like PythagoreanTree, so at least it's less confusing.
This is still based on #1786 since that fixes the PythagoreanTree compatibility.
Includes