[FIX] Copy data attributes for annotated data set #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.25% (diff: 100%)@@ master #1895 diff @@
==========================================
Files 86 86
Lines 9100 9100
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8122 8122
Misses 978 978
Partials 0 0
|
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 10, 2017
[FIX] Copy data attributes for annotated data set (cherry picked from commit 097bf2a)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 11, 2017
[FIX] Copy data attributes for annotated data set (cherry picked from commit 097bf2a)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 13, 2017
[FIX] Copy data attributes for annotated data set (cherry picked from commit 097bf2a)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 18, 2017
[FIX] Copy data attributes for annotated data set (cherry picked from commit 097bf2a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Any annotations that accompany the data set are passed from widget to widget by
attributesattribute of the data table. Essentially, the attributes should be inherited from the input data set. Where the new, resulting data set is build from scratch (say, with Orange.data.Table), the attributes have to be copied manually (e.g.,new_table.attributes = old_table.attributes). This was not done in the create_annotated_table function which is used by several widgets (Data Table, MDS, Hierarchical Clustering), resulting in crashes of the widgets that rely on table attributes.Description of changes
Attributes are now set for the newly constructed table by copying from input data table.
Includes