Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWBoxPlot: Fix ordering of boxes #1900

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Jan 9, 2017

Issue

When display selection changed (i.e. from No comparison to Compare means), labels changed position but boxes stayed at the same place.

Description of changes

To reproduce: File (iris) -> BoxPlot. Open BoxPlot and switch between No comparison and Compare means.

Includes
  • Code changes
  • Tests
  • Documentation

@lanzagar lanzagar changed the title OWComboBox: Fix ordering of boxes [FIX] OWBoxPlot: Fix ordering of boxes Jan 9, 2017
@codecov-io
Copy link

codecov-io commented Jan 9, 2017

Current coverage is 89.28% (diff: 100%)

Merging #1900 into master will not change coverage

@@             master      #1900   diff @@
==========================================
  Files            86         86          
  Lines          9109       9109          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           8133       8133          
  Misses          976        976          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 53c81fd...8d19bee

@astaric
Copy link
Member

astaric commented Jan 11, 2017

When I run this, I get a bunch of warnings printed to the console:

QGraphicsScene::addItem: item has already been added to this scene

They are not there on widget from master.

@VesnaT VesnaT force-pushed the fix_cb_comparison branch from f361534 to 8d19bee Compare January 11, 2017 12:45
@VesnaT
Copy link
Contributor Author

VesnaT commented Jan 11, 2017

Fixed

@VesnaT VesnaT added this to the 3.3.10 milestone Jan 13, 2017
@lanzagar lanzagar merged commit be928f7 into biolab:master Jan 13, 2017
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 18, 2017
[FIX] OWBoxPlot: Fix ordering of boxes
(cherry picked from commit be928f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants