[FIX] owfeaturecontructor: Fix an IndexError accessing exception's args #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception's `args` member can be an empty tuple if an exception is constructed without any arguments (neither is it necessarily a string as the code assumed). Use `traceback.format_exception_only` helper to display the exception message. Also log the full stack trace for easier debugging.
Current coverage is 89.25% (diff: 100%)@@ master #1905 diff @@
==========================================
Files 86 86
Lines 9100 9100
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8122 8122
Misses 978 978
Partials 0 0
|
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 18, 2017
…uctor-index-error [FIX] owfeaturecontructor: Fix an IndexError accessing exception's args (cherry picked from commit 4dad654)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Indexing exception's args member in owfeatureconstructor.py#L584 can raise an IndexError when an exception is constructed without arguments
Description of changes
Use
traceback.format_exception_onlyhelper to display the exception message. Also log the full stack trace for easier debugging.Includes