[FIX] Table.__repr__: Fix for sparse data with < 5 instances #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikicc
force-pushed
the
repr_on_small_sparse
branch
from
317aa53
to
5ee3193
Compare
lanzagar
approved these changes
Jan 25, 2017
|
A test would be nice :) |
Scipy does not support indexing table[:5] if table has less than 5 rows.
nikicc
force-pushed
the
repr_on_small_sparse
branch
from
5ee3193
to
c6f94f2
Compare
|
Simple test was added. Also, checking for sparse was replaced with |
Current coverage is 89.44% (diff: 100%)@@ master #1951 diff @@
==========================================
Files 86 86
Lines 9119 9122 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 8146 8159 +13
+ Misses 973 963 -10
Partials 0 0
|
astaric
pushed a commit
that referenced
this pull request
Feb 3, 2017
[FIX] Table.__repr__: Fix for sparse data with < 5 instances (cherry picked from commit 3878b7b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1950.
Description of changes
Fix
Table.__repr__for sparse.Includes