[FIX] Paint Data: in-place output modification #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The widget used to output a table created from a view of its buffer which should have been used only internally to the widget as it can be modified in-place. Fixes biolabgh-1926
Fixes a 'QUndoStack::endMacro(): no matching beginMacro()' warning from Qt and creates a single Undo command
ales-erjavec
force-pushed
the
fixed/paint-data-inplace-mod
branch
from
6447410 to
4faf8fa
Compare
Current coverage is 89.50% (diff: 100%)@@ master #1959 diff @@
==========================================
Files 89 89
Lines 9166 9166
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8204 8204
Misses 962 962
Partials 0 0
|
astaric
pushed a commit
that referenced
this pull request
Feb 3, 2017
[FIX] Paint Data: in-place output modification (cherry picked from commit 2ef581e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The widget outputs a table created from a view of its data which should have been used only internally to the widget as it is modified in-place.
Description of changes
Ensure the output data is not a view of the working data.
Includes