[FIX] File: Fix crash when last_path is None #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
file-no-last-path
branch
from
eb10f40 to
846200f
Compare
|
Could you also write a test that reproduces the problem? |
janezd
force-pushed
the
file-no-last-path
branch
from
846200f to
4781444
Compare
|
I didn't think so. It turned out it's trivial. |
Current coverage is 89.53% (diff: 100%)@@ master #1961 diff @@
==========================================
Files 90 90
Lines 9179 9179
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8218 8218
Misses 961 961
Partials 0 0
|
janezd
changed the title
astaric
pushed a commit
that referenced
this pull request
Feb 3, 2017
[FIX] File: Fix crash when last_path is None (cherry picked from commit f3ebda7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sentry.io/biolab/orange3/issues/196743788/
The error also appeared when I tried to reproduce some unrelated bugs.
Description of changes
Check whether
last_pathisNonebefore checking its size.Includes