Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] OWSGD: Output coefficients #1981

Merged
merged 2 commits into from
Feb 8, 2017
Merged

[ENH] OWSGD: Output coefficients #1981

merged 2 commits into from
Feb 8, 2017

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Jan 31, 2017

Issue

Output coefficients for SGD classification and regression widgets

Description of changes

Use Orange preprocessors instead of sklearn Pipeline

Modify OWSGD ancestor to output coefficients

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Jan 31, 2017

Codecov Report

Merging #1981 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master    #1981      +/-   ##
==========================================
+ Coverage   89.45%   89.46%   +<.01%     
==========================================
  Files          90       90              
  Lines        9182     9189       +7     
==========================================
+ Hits         8214     8221       +7     
  Misses        968      968

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed69cd5...6cad0b3. Read the comment docs.

@lanzagar
Copy link
Contributor

lanzagar commented Feb 1, 2017

Using Orange's preprocessors instead of sklearn Pipeline could result in a simpler fix.
Could you look into it?

@VesnaT
Copy link
Contributor Author

VesnaT commented Feb 2, 2017

Will do.

@VesnaT VesnaT changed the title OWSGD: Output coefficients [ENH] OWSGD: Output coefficients Feb 2, 2017
@astaric astaric merged commit 2fbe656 into biolab:master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants