Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] scatterplot: Fix density image #1990

Merged
merged 2 commits into from
Feb 3, 2017

Conversation

thocevar
Copy link
Contributor

@thocevar thocevar commented Feb 3, 2017

Issue

The density image (crashes) in scatterplot doesn't display with the latest version of pyqtgraph 0.10.

Description of changes

Change the dtype of the computed numpy array of pixel values to reflect the actual range of values and prevent "automatic" scaling (crashing) by pyqtgraph.

Includes
  • Code changes
  • Tests
  • Documentation

@astaric astaric added this to the 3.3.11 milestone Feb 3, 2017
@astaric
Copy link
Member

astaric commented Feb 3, 2017

It works, thanks.

@codecov-io
Copy link

codecov-io commented Feb 3, 2017

Codecov Report

Merging #1990 into master will increase coverage by -0.03%.

@@            Coverage Diff             @@
##           master    #1990      +/-   ##
==========================================
- Coverage   89.47%   89.45%   -0.03%     
==========================================
  Files          91       91              
  Lines        9198     9198              
==========================================
- Hits         8230     8228       -2     
- Misses        968      970       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5841f7...79cd432. Read the comment docs.

@astaric astaric self-assigned this Feb 3, 2017
@astaric astaric merged commit 8921dd8 into biolab:master Feb 3, 2017
astaric added a commit that referenced this pull request Feb 3, 2017
[FIX] scatterplot: Fix density image
(cherry picked from commit 8921dd8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants