Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Highcharts: Fix freezing on Qt5 #2015

Merged
merged 4 commits into from
Feb 14, 2017
Merged

Conversation

kernc
Copy link
Contributor

@kernc kernc commented Feb 13, 2017

Issue

Highcharts froze on Qt5.

Description of changes

No longer freezes on Qt5 by passing a core object into JS by a different mechanism and at a different time.

Includes
  • Code changes
  • Tests
  • Documentation

@kernc kernc force-pushed the fix-webengine-qt5 branch from 1247eca to 3b06868 Compare February 13, 2017 17:52
@codecov-io
Copy link

codecov-io commented Feb 13, 2017

Codecov Report

Merging #2015 into master will decrease coverage by -4.22%.
The diff coverage is 7.4%.

@@            Coverage Diff             @@
##           master    #2015      +/-   ##
==========================================
- Coverage    70.4%   66.18%   -4.22%     
==========================================
  Files         343      343              
  Lines       54074    54087      +13     
==========================================
- Hits        38070    35799    -2271     
- Misses      16004    18288    +2284

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682a939...9ce670f. Read the comment docs.

@kernc kernc force-pushed the fix-webengine-qt5 branch from 9162c84 to 45bf69e Compare February 13, 2017 18:11
@kernc kernc changed the title Highcharts: Fix freezing on Qt5 [FIX] Highcharts: Fix freezing on Qt5 Feb 13, 2017
@astaric
Copy link
Member

astaric commented Feb 13, 2017

Tests still timeout on appveyor :(

@astaric astaric added this to the 3.3.12 milestone Feb 13, 2017
@kernc kernc force-pushed the fix-webengine-qt5 branch from 45bf69e to f20a92d Compare February 13, 2017 19:47
Before this change, the widget froze in _JSObjectChannel.send_object().
... and no longer a callable Qt property.
@kernc kernc force-pushed the fix-webengine-qt5 branch 3 times, most recently from 35ef964 to 71debec Compare February 14, 2017 12:33
@kernc kernc force-pushed the fix-webengine-qt5 branch from 71debec to 9ce670f Compare February 14, 2017 12:56
@astaric astaric merged commit 5373929 into biolab:master Feb 14, 2017
astaric added a commit to astaric/orange3 that referenced this pull request Feb 14, 2017
[FIX] Highcharts: Fix freezing on Qt5
(cherry picked from commit 5373929)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants