Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] SelectRows: Fix loading of conditions #2065

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

astaric
Copy link
Member

@astaric astaric commented Mar 2, 2017

Issue

Conditions in select rows are not loaded properly when reading from file (gh-2062)

Description of changes

Make sure the correct ordering of variables is used when restoring conditions.

Includes
  • Code changes
  • Tests
  • Documentation

@astaric astaric force-pushed the select-rows-load-settings branch from 6546931 to d676ee7 Compare March 2, 2017 13:28
@codecov-io
Copy link

codecov-io commented Mar 2, 2017

Codecov Report

Merging #2065 into master will decrease coverage by -2.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2065      +/-   ##
==========================================
- Coverage    70.7%   68.64%   -2.06%     
==========================================
  Files         315      315              
  Lines       53903    53923      +20     
==========================================
- Hits        38111    37015    -1096     
- Misses      15792    16908    +1116

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b1813c...1283ce2. Read the comment docs.

@astaric astaric force-pushed the select-rows-load-settings branch from d676ee7 to 1283ce2 Compare March 2, 2017 13:32
@lanzagar lanzagar merged commit eb53e99 into biolab:master Mar 3, 2017
@astaric astaric deleted the select-rows-load-settings branch September 8, 2017 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants