[FIX] Discover widgets when some dependencies are missing #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ales-erjavec does this make sense? It solves the problem mentioned in #1753, but I might be missing something. |
.resolve() is available from setuptools 11.3 forward (released in 2015), does the same thing as .load(), but ommits the requirements check.
astaric
force-pushed
the
entry-point-resolve
branch
from
320d184
to
1be59dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #2103 +/- ##
=======================================
Coverage 71.27% 71.27%
=======================================
Files 318 318
Lines 54265 54265
=======================================
Hits 38678 38678
Misses 15587 15587Continue to review full report at Codecov.
|
astaric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When one of the requirements (of their requirements (or their requirements...)) is missing, Orange opens with no widgets.
To reproduce, uninstall keyring and open canvas
Description of changes
use .resolve() to load entry points
.resolve() is available from setuptools 11.3 forward (released in 2015),
does the same thing as .load(), but ommits the requirements check.
Includes