[FIX] All widgets are set to auto* when they are used for the first time #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All widgets are set to autocommit/autoapply/autosend when they are used for the first time GH-2038
astaric
reviewed
Mar 30, 2017
| @@ -386,7 +386,7 @@ def __init__(self): | |||
| self.in_learner = None | |||
| self.in_classifier = None | |||
| self.in_object = None | |||
| self.auto_execute = False | |||
There was a problem hiding this comment.
This is a bad idea. If it is supposed to be a setting, changing it to false/true in init overrides the saved value.
astaric
approved these changes
Mar 30, 2017
Codecov Report
@@ Coverage Diff @@
## master #2136 +/- ##
==========================================
- Coverage 71.55% 71.49% -0.06%
==========================================
Files 318 318
Lines 54475 54420 -55
==========================================
- Hits 38979 38909 -70
- Misses 15496 15511 +15Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
All widgets are set to autocommit/autoapply/autosend/autoexecute when they are used for the first time.
Python Script test changed.
GH-2038
Includes