Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix invalid settings reuse in File widget #2137

Merged
merged 2 commits into from
Mar 27, 2017

Conversation

astaric
Copy link
Member

@astaric astaric commented Mar 24, 2017

Issue

When files with similar domain (same variable names, different values of discrete vars) were opened, domain editor always showed values from the first opened file.

Fixes gh-2132

Description of changes

ContextHandler now takes variable's values in account.

Includes
  • Code changes
  • Tests

@astaric astaric changed the title [Fix] [FIX] Fix invalid settings reuse in File widget Mar 24, 2017
@astaric astaric force-pushed the file-match-values branch from f70f9e1 to 8440ab4 Compare March 24, 2017 10:43
@codecov-io
Copy link

codecov-io commented Mar 24, 2017

Codecov Report

Merging #2137 into master will decrease coverage by 4.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2137      +/-   ##
==========================================
- Coverage   71.49%   67.47%   -4.02%     
==========================================
  Files         318      318              
  Lines       54423    54428       +5     
==========================================
- Hits        38908    36725    -2183     
- Misses      15515    17703    +2188

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a022b...ee02816. Read the comment docs.

As domain editor shows variable's values, it should only reuse settings
when two discrete variables have the same settings.
@astaric astaric force-pushed the file-match-values branch from 8440ab4 to ee02816 Compare March 24, 2017 10:44
def test_context_match_includes_variable_values(self):
file1="""\
var
a b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you not add two or three more tabs? For instance see https://github.com/biolab/orange3/pull/2120/files#diff-27440f7faaa4fc96168ff656e6891bdeR154

@jerneju jerneju merged commit db543d6 into biolab:master Mar 27, 2017
@astaric astaric deleted the file-match-values branch September 8, 2017 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants