[FIX] Preprocess: enums containing function names changed #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enums now saved as string and not as int anymore. https://sentry.io/biolab/orange3/issues/227119437/
Codecov Report
@@ Coverage Diff @@
## master #2151 +/- ##
=======================================
Coverage 71.55% 71.55%
=======================================
Files 318 318
Lines 54470 54470
=======================================
Hits 38976 38976
Misses 15494 15494Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When loaded schema from file, function names are loaded as integers. That is why functions cannot be called anymore (int is not callable).
https://sentry.io/biolab/orange3/issues/227119437/
Description of changes
Enums in Scale preprocess now saved as string and not as int anymore.
Includes