Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Reimplement macOS application (.app) build scripts #2217

Merged
merged 3 commits into from
Apr 12, 2017

Conversation

ales-erjavec
Copy link
Contributor

Issue

Update macOS application to use a newer Python (3.6) and Qt (5.8)

Description of changes

Replace the old build scripts. There is no prebuild bundle template anymore. The python framework is downloaded/extracted from the official python.org macOS pkg installers, laid out into the .app directory and made relocatable (using install_name_tool to change .dylib' library load paths relative).

All other dependencies are then installed using pip/wheel

However with Python 3.6 we are now responsible for distributing a ssl certificate store.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Apr 11, 2017

Codecov Report

Merging #2217 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2217   +/-   ##
=======================================
  Coverage   72.17%   72.17%           
=======================================
  Files         318      318           
  Lines       54765    54765           
=======================================
  Hits        39526    39526           
  Misses      15239    15239

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3690174...ef1e6e4. Read the comment docs.

@astaric
Copy link
Member

astaric commented Apr 11, 2017

When I build an app using this script and run it, Orange menu lists

  • About main.py
  • Hide main.py

Would it be possible to rename those entries?

@ales-erjavec
Copy link
Contributor Author

Would it be possible to rename those entries?

Should be fixed now.

Qt 5.8 only supports 10.9.0 and later.
@astaric
Copy link
Member

astaric commented Apr 11, 2017

Looks ok to me. Can I merge it or will it break the daily builds?

@janezd
Copy link
Contributor

janezd commented Apr 11, 2017

I have one more question: can we decrease the bundle size? A year or two ago I noticed that we distribute a lot of stuff, perhaps even QtDesigner, in the bundle.

@ales-erjavec
Copy link
Contributor Author

ales-erjavec commented Apr 11, 2017

Can I merge it or will it break the daily builds?

The daily builds are already broken, so this cannot hurt much.

can we decrease the bundle size?

I do not think so. This one is about 20MB lighter than before (122MB).

@astaric astaric merged commit 568cefb into biolab:master Apr 12, 2017
@ales-erjavec ales-erjavec deleted the osx-app-reboot branch May 12, 2017 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants