-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Support Sparse Data in Domain Editor #2245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikicc
force-pushed
the
edit-domain-sparse
branch
from
April 19, 2017 08:21
e573b53
to
e734aa8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2245 +/- ##
==========================================
+ Coverage 72.37% 72.39% +0.01%
==========================================
Files 319 319
Lines 55014 55056 +42
==========================================
+ Hits 39819 39858 +39
- Misses 15195 15198 +3 |
jerneju
approved these changes
Apr 20, 2017
nikicc
force-pushed
the
edit-domain-sparse
branch
2 times, most recently
from
April 21, 2017 13:12
c54a56a
to
35727c9
Compare
Can you reduce complexity? |
nikicc
force-pushed
the
edit-domain-sparse
branch
from
April 21, 2017 14:05
35727c9
to
58909e4
Compare
nikicc
force-pushed
the
edit-domain-sparse
branch
2 times, most recently
from
April 21, 2017 14:27
2516b82
to
e4385c6
Compare
|
jerneju
suggested changes
Apr 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open corpus file, then iris, and then again corpus.
nikicc
force-pushed
the
edit-domain-sparse
branch
from
April 21, 2017 14:48
e4385c6
to
7362c81
Compare
nikicc
force-pushed
the
edit-domain-sparse
branch
from
April 21, 2017 15:25
7362c81
to
d90f5a8
Compare
@jerneju should be fixed now, please check again. |
jerneju
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2188.
Description of changes
Enhance
DomainEditor.get_domain
to handle sparse data. Also instead of returning a list of columns' the method itself merges them to appropriateX
,y
andmeta
arrays.Includes