Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Test & Score: Instantly recognize new input #2247

Merged
merged 1 commit into from
Apr 24, 2017
Merged

[FIX] Test & Score: Instantly recognize new input #2247

merged 1 commit into from
Apr 24, 2017

Conversation

jerneju
Copy link
Contributor

@jerneju jerneju commented Apr 19, 2017

Issue

#1842
#2219

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@jerneju jerneju requested review from janezd and ajdapretnar April 19, 2017 12:10
@codecov-io
Copy link

codecov-io commented Apr 19, 2017

Codecov Report

Merging #2247 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master    #2247   +/-   ##
=======================================
  Coverage   72.37%   72.37%           
=======================================
  Files         319      319           
  Lines       55014    55014           
=======================================
  Hits        39819    39819           
  Misses      15195    15195

@lanzagar lanzagar self-assigned this Apr 21, 2017

if self.test_data is not None and \
self.resampling != OWTestLearners.TestOnTest:
self.Warning.test_data_unused()

if len(items) == 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of moving the check on items away from its creation, how about moving the check for TestOnTest up, together with other similar checks. The ifs can even be merged.

Otherwise this seems to fix the problem :)

@lanzagar lanzagar merged commit f593bbf into biolab:master Apr 24, 2017
@jerneju jerneju deleted the gh-1842-test-score branch April 24, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants