[ENH] Check if updates are available upon startup #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2273 +/- ##
==========================================
- Coverage 73.2% 73.19% -0.02%
==========================================
Files 316 316
Lines 55289 55289
==========================================
- Hits 40475 40468 -7
- Misses 14814 14821 +7 |
astaric
reviewed
May 3, 2017
Orange/canvas/__main__.py
Outdated
| settings.setValue("startup/show-survey", not success) | ||
| else: | ||
| settings.setValue("startup/show-survey", result != QMessageBox.No) | ||
|
|
||
| question.finished.connect(handle_response) | ||
| question.show() | ||
|
|
||
| check_updates = settings.value('startup/check-updates', True, type=bool) |
There was a problem hiding this comment.
Could this code be put in a separate function, called here with settings as parameter?
main is already too long and I am not fond of making it even longer
kernc
force-pushed
the
updates-available
branch
4 times, most recently
from
367dd30
to
3d3123e
Compare
kernc
changed the title
kernc
changed the title
astaric
approved these changes
May 16, 2017
jerneju
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Too many users using stale Orange versions.
Description of changes
Upon application startup, check if newer software version is available.
Includes