Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owmanifoldlearning: Remove n_jobs=-2 parameter #2371

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

ales-erjavec
Copy link
Contributor

Issue

Manifold Learning frequently deadlocks with the forking multiprocessing backend and a
threaded blas library.

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

Frequently deadlocks with the forking multiprocessing backend and
threaded blas library.
@kernc
Copy link
Contributor

kernc commented Jun 2, 2017

Is it likely that setting the default multiprocessing start method to forkserver should mitigate this?

@codecov-io
Copy link

Codecov Report

Merging #2371 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2371      +/-   ##
==========================================
+ Coverage   73.41%   73.41%   +<.01%     
==========================================
  Files         317      317              
  Lines       55653    55653              
==========================================
+ Hits        40859    40860       +1     
+ Misses      14794    14793       -1

@ales-erjavec
Copy link
Contributor Author

Is it likely that setting the default multiprocessing start method to forkserver should mitigate this?

Probably. But I would still prefer not to.

@lanzagar lanzagar merged commit 436b6d2 into biolab:master Jun 16, 2017
@lanzagar lanzagar added this to the 3.4.4 milestone Jun 16, 2017
@ales-erjavec ales-erjavec deleted the manifold-learning-njobs branch June 21, 2017 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants