-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Error Reporting: open encode as unicode #2416
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2416 +/- ##
==========================================
+ Coverage 73.9% 77.22% +3.32%
==========================================
Files 321 325 +4
Lines 55993 64896 +8903
==========================================
+ Hits 41379 50118 +8739
- Misses 14614 14778 +164 |
My first question after seeing this PR was --- why? Is this needed because |
Is this still WIP? Plus, can you answer the above question so we can proceed with the PR? |
I have not reproduced this bug yet, so now I am (temporarily?) closing this PR. |
Run
|
Now I reproduced this error, tested it and this fix works. |
Issue
Description of changes
Includes