[FIX] Feature Constructor: no fail when no values #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2417 +/- ##
=========================================
- Coverage 74.25% 73.9% -0.36%
=========================================
Files 320 320
Lines 55786 55799 +13
=========================================
- Hits 41425 41236 -189
- Misses 14361 14563 +202 |
janezd
reviewed
Jun 21, 2017
| @@ -244,7 +244,7 @@ def setEditorData(self, data, domain): | |||
| def editorData(self): | |||
| values = self.valuesedit.text() | |||
| values = re.split(r"(?<!\\),", values) | |||
| values = tuple(v.replace(r"\,", ",").strip() for v in values) | |||
| values = tuple(filter(None, [v.replace(r"\,", ",").strip() for v in values])) | |||
There was a problem hiding this comment.
You can use generators instead of list comprehension, that is
values = tuple(filter(None, (v.replace(r",", ",").strip() for v in values)))
| @@ -292,7 +292,7 @@ def data(self, index, role=Qt.DisplayRole): | |||
| return super().data(index, role) | |||
|
|
|||
|
|
|||
| class FeatureConstructorSettingsHandler(DomainContextHandler): | |||
| class FeatureConstructorHandler(DomainContextHandler): | |||
There was a problem hiding this comment.
I preferred the original name. In fact, I'd call it FeatureConstructorContextHandler and disable the pylint's warning. The current name suggest that it handles the feature constructor, not its contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Error occurs when Values box is empty.
Description of changes
Includes