Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owsql: Fixes for Custom SQL option #2456

Merged
merged 2 commits into from
Jul 10, 2017
Merged

Conversation

lanzagar
Copy link
Contributor

@lanzagar lanzagar commented Jul 7, 2017

Issue
  1. Custom SQL had a case-sensitive check for SELECT (lower case did not work correctly)
  2. Only psycopg2.ProgrammingError was caught, but after refactoring the BackendError can be thrown as well
Description of changes
  1. case-insensitive check
  2. catch both errors
Includes
  • Code changes
  • Tests
  • Documentation

@lanzagar lanzagar changed the title owsql: Fixes for Custom SQL option [FIX] owsql: Fixes for Custom SQL option Jul 7, 2017
@codecov-io
Copy link

Codecov Report

Merging #2456 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #2456      +/-   ##
==========================================
- Coverage   74.33%   74.32%   -0.01%     
==========================================
  Files         321      321              
  Lines       55988    55988              
==========================================
- Hits        41616    41614       -2     
- Misses      14372    14374       +2

@astaric astaric merged commit 95fe731 into biolab:master Jul 10, 2017
@astaric astaric deleted the sql branch July 10, 2017 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants