-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Widget status bar buttons #2514
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2514 +/- ##
=========================================
Coverage ? 75.24%
=========================================
Files ? 332
Lines ? 57875
Branches ? 0
=========================================
Hits ? 43547
Misses ? 14328
Partials ? 0 |
a15ca60
to
cbcaa8c
Compare
b2e729b
to
59927bb
Compare
e7e37cb
to
27994b6
Compare
27994b6
to
d01dd4d
Compare
* Move the default standard 'Report', 'Save Image' buttons to the status bar * The old push buttons are still created but are not inserted into any layout to preserve source compatibility.
Show the help button in the status bar when enabled. This is done by the canvas framework - it is responsible for providing the help.
d01dd4d
to
36d86ce
Compare
Perhaps I should go through all widgets and remove the manually rearranged push buttons? And, perhaps, also through all other widgets and see whether their layout after this PR is still OK? I'd then push the corresponding commits into this PR, so we can finally merge it? @ales-erjavec, would this be OK? |
I would rather not do that in this pull request. Keeping and using the back-compatibility guarantee at least for a little while is the best test that it works. |
I didn't mean to remove the back-compatibility. It's going to stay there since add-ons may shuffle the buttons, too. I just wanted to remove the extra report buttons appearing in the widgets, and fix any broken layouts in the widgets from which the button was removed. I went through all core widgets now, and the layout is mostly fine, so ... merging. |
Issue
Move standard Report/Save Image ... buttons to the status bar
Description of changes
Deprecate. The old QPushButtons are still created but are not inserted into any layout or parent hierarchy. Any subclass that inserted them into other layouts (there are plenty examples of this) should still work.buttons_area_orientation
and thebuttonsArea
Includes