Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Widget status bar buttons #2514

Merged
merged 5 commits into from
Oct 9, 2017

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Aug 3, 2017

Issue

Move standard Report/Save Image ... buttons to the status bar

Description of changes
  • Provide a standard buttons for common actions in the OWWidget statusbar.
  • Deprecate buttons_area_orientation and the buttonsArea. The old QPushButtons are still created but are not inserted into any layout or parent hierarchy. Any subclass that inserted them into other layouts (there are plenty examples of this) should still work.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Aug 3, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@1a3247f). Click here to learn what that means.
The diff coverage is 98.88%.

@@            Coverage Diff            @@
##             master    #2514   +/-   ##
=========================================
  Coverage          ?   75.24%           
=========================================
  Files             ?      332           
  Lines             ?    57875           
  Branches          ?        0           
=========================================
  Hits              ?    43547           
  Misses            ?    14328           
  Partials          ?        0

@ales-erjavec ales-erjavec force-pushed the widget-status-bar-buttons branch 4 times, most recently from a15ca60 to cbcaa8c Compare August 16, 2017 08:37
@ales-erjavec ales-erjavec force-pushed the widget-status-bar-buttons branch 2 times, most recently from b2e729b to 59927bb Compare August 21, 2017 07:28
@ales-erjavec ales-erjavec changed the title [NOMERGE][RFC][ENH] Widget status bar buttons [ENH] Widget status bar buttons Aug 31, 2017
@ales-erjavec ales-erjavec force-pushed the widget-status-bar-buttons branch 2 times, most recently from e7e37cb to 27994b6 Compare September 5, 2017 15:06
* Move the default standard 'Report', 'Save Image' buttons to the
  status bar
* The old push buttons are still created but are not inserted into any
  layout to preserve source compatibility.
Show the help button in the status bar when enabled. This is
done by the canvas framework - it is responsible for providing
the help.
@janezd
Copy link
Contributor

janezd commented Oct 5, 2017

Perhaps I should go through all widgets and remove the manually rearranged push buttons? And, perhaps, also through all other widgets and see whether their layout after this PR is still OK? I'd then push the corresponding commits into this PR, so we can finally merge it?

@ales-erjavec, would this be OK?

@ales-erjavec
Copy link
Contributor Author

I would rather not do that in this pull request. Keeping and using the back-compatibility guarantee at least for a little while is the best test that it works.

@janezd
Copy link
Contributor

janezd commented Oct 9, 2017

I didn't mean to remove the back-compatibility. It's going to stay there since add-ons may shuffle the buttons, too. I just wanted to remove the extra report buttons appearing in the widgets, and fix any broken layouts in the widgets from which the button was removed.

I went through all core widgets now, and the layout is mostly fine, so ... merging.

@janezd janezd merged commit bee63b7 into biolab:master Oct 9, 2017
@ales-erjavec ales-erjavec deleted the widget-status-bar-buttons branch November 14, 2017 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants